Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented std paddle frontend #22075

Merged
merged 3 commits into from
Aug 18, 2023
Merged

implemented std paddle frontend #22075

merged 3 commits into from
Aug 18, 2023

Conversation

sumayyahc1
Copy link
Contributor

Added std function to Paddle frontend, and added the test function. However, the test is failing with the error: AssertionError: Frontend function returned non-frontend arrays. I'm not sure how to fix this.

Close #22067

@github-actions
Copy link
Contributor

Thanks for contributing to Ivy! 😊👏
Here are some of the important points from our Contributing Guidelines 📝:
1. Feel free to ignore the run_tests (1), run_tests (2), … jobs, and only look at the display_test_results job. 👀 It contains the following two sections:
- Combined Test Results: This shows the results of all the ivy tests that ran on the PR. ✔️
- New Failures Introduced: This lists the tests that are passing on main, but fail on the PR Fork. Please try to make sure that there are no such tests. 💪
2. The lint / Check formatting / check-formatting tests check for the formatting of your code. 📜 If it fails, please check the exact error message in the logs and fix the same. ⚠️🔧
3. Finally, the test-docstrings / run-docstring-tests check for the changes made in docstrings of the functions. This may be skipped, as well. 📚
Happy coding! 🎉👨‍💻

@ivy-leaves ivy-leaves added the Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist label Aug 17, 2023
@nassimberrada
Copy link
Contributor

Hi @sumayyahc1, thank you for contributing! I'm not sure I'm seeing the error you mentioned, I would suggest you take a look at the the test results in display_test_results as explained in the github-actions comment above. Your PR looks good overall but there seems to be a few issues to address. Let me know when you'd like another review, thanks!

@sumayyahc1
Copy link
Contributor Author

@nassimberrada I got the error when I ran the tests locally but I just realized I didn't finish the setup correctly. display_test_results doesn't show any failures.

Can you please let me know what other issues are present? Thanks!

@nassimberrada
Copy link
Contributor

Hey @sumayyahc1, just a note on the diplay_test_results, even if it's passing you would still need to go to Details then New Failures Introduced where you would see that paddle_std is failing for all backends. Checking the Falsifying Examples for test_paddle_std within Combined Test Results should give you more details on the nature of the issues. Hope this helps, thanks!

@sumayyahc1
Copy link
Contributor Author

@nassimberrada test_paddle_std is running successfully now.

@nassimberrada
Copy link
Contributor

Looks good, merging. Thanks again for your contribution!

@nassimberrada nassimberrada merged commit 825b709 into ivy-llc:main Aug 18, 2023
124 of 133 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Paddle Frontend Developing the Paddle Frontend, checklist triggered by commenting add_frontend_checklist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

std
3 participants